fix(#114): properly handle association proxy#115
Merged
indiVar0508 merged 2 commits intomasterfrom Nov 28, 2023
Merged
Conversation
Pull Request Test Coverage Report for Build 6987599987
💛 - Coveralls |
AbdealiLoKo
reviewed
Nov 25, 2023
sqlalchemy_history/builder.py
Outdated
| for cls in version_classes: | ||
| assoc_prox_maps = get_association_proxies(cls) | ||
| for key, prop in assoc_prox_maps.items(): | ||
| for key, _prop in assoc_prox_maps.items(): |
Contributor
There was a problem hiding this comment.
If prop is not required - use .keys() ?
we added association proxy support in versioned class but it was incorrect as we were setting proxy attribute to versioned class and we didn't caught it because we didn't have test for that so added that.
aditya051293
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we added association proxy support in versioned class but it was incorrect as we were setting proxy attribute to versioned class and we didn't caught it because we didn't have test for that so added that.