Skip to content

chore: minor fixes in CI and project dependency #117

Merged
indiVar0508 merged 3 commits intomasterfrom
indi-due3
Nov 29, 2023
Merged

chore: minor fixes in CI and project dependency #117
indiVar0508 merged 3 commits intomasterfrom
indi-due3

Conversation

@indiVar0508
Copy link
Copy Markdown
Contributor

ref: kvesteri/sqlalchemy-utils#719 ref: sqlalchemy/sqlalchemy#10474 (reply in thread) There is incorrect API being invoked for generic-relationship due to which Activity plugin tests are failing so skipping those tests for sqla=2.x series.

ref: kvesteri/sqlalchemy-utils#719
ref: sqlalchemy/sqlalchemy#10474 (reply in thread)
There is incorrect API being invoked for generic-relationship
due to which Activity plugin tests are failing so skipping those
tests for sqla=2.x series.
flag name should reflect on project level so coveralls knows
what files to be merged.
lint job was not checking for format but formatting it so it was
not failing added check flag.
formatted files that needed to be formatted
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7028423896

  • 10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on indi-due3 at 93.66%

Totals Coverage Status
Change from base Build 7015162924: 93.7%
Covered Lines: 4888
Relevant Lines: 5152

💛 - Coveralls

@indiVar0508 indiVar0508 changed the title chore: don't pin sqla 2.x, instead skip tests for activity chore: minor fixes in CI and project dependency Nov 29, 2023
@indiVar0508 indiVar0508 enabled auto-merge (rebase) November 29, 2023 05:36
@indiVar0508 indiVar0508 merged commit f94ff1b into master Nov 29, 2023
@indiVar0508 indiVar0508 deleted the indi-due3 branch November 29, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants