Merged
Conversation
Contributor
Author
|
Please add hactoberfest label thank you. |
AbdealiLoKo
reviewed
Nov 3, 2022
sqlalchemy_history/operation.py
Outdated
|
|
||
| def iteritems(self): | ||
| return six.iteritems(self.objects) | ||
| return iter(self.objects) |
Contributor
There was a problem hiding this comment.
six.iteritems gives is a iterator of key, val pairs.
But iter() will just give us an iterator for keys
So, this is not equivalent
In fact - I think we can just remove this function because iteritems is not a function people in py3 use after dict_items was added in py3
AbdealiLoKo
force-pushed
the
remove_six_usage
branch
from
45dabfc to
f4f2c39
Compare
AbdealiLoKo
approved these changes
Nov 3, 2022
Six is useful for py2 and py3 compatibility. We only support py3.6+ So, we don't require six anymore
AbdealiLoKo
force-pushed
the
remove_six_usage
branch
from
f4f2c39 to
cfd4eee
Compare
Contributor
|
Thanks for the contribution @kishan3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #13