Add python_requires 3.6+ to setup.py#18
Merged
AbdealiLoKo merged 1 commit intocorridor:masterfrom Nov 3, 2022
Merged
Conversation
Contributor
|
Hi @15jgme , yeah it makes sense can you also remove that in this commit itself |
Contributor
Author
|
Hi @indiVar0508, for sure. Should be fixed now. |
AbdealiLoKo
force-pushed
the
Add_py_version_requirements
branch
from
b105b76 to
24962e7
Compare
Going forward this library will only support py3.6+ and sqla1.4+ So, add python_requires in setuptools
AbdealiLoKo
force-pushed
the
Add_py_version_requirements
branch
from
24962e7 to
6192cd3
Compare
AbdealiLoKo
approved these changes
Nov 3, 2022
Contributor
|
Thanks a lot for the contribution @15jgme |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #10
Enforce a python version greater than 3.6 during install.
For pypi it may also be desirable to remove the following lines from setup.py as these versions will no longer be installable.
73 'Programming Language :: Python :: 2',74 'Programming Language :: Python :: 2.7',76 'Programming Language :: Python :: 3.4',77 'Programming Language :: Python :: 3.5',