Conversation
indiVar0508
force-pushed
the
chore_items
branch
2 times, most recently
from
c544b58 to
a024fc7
Compare
.pre-commit-config.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| repos: | |||
| - repo: https://github.com/pre-commit/pre-commit-hooks | |||
There was a problem hiding this comment.
pre-commit and link are not tied together.
We should use pre-commit as a subset of the lint checks we do in github actions.
We should add flake8 to the project (independent of pre-commit) and merge that as a separate commit
There was a problem hiding this comment.
After than, another commit for add pre-commit
And document in this file maybe that the pre-commit configurations for black have not been added because of py3.6 compat issues between pre-commit and black
.github/workflows/main.yml
Outdated
| - uses: psf/black@stable | ||
|
|
||
| test-sqlite: | ||
| needs: |
There was a problem hiding this comment.
Chaining the tasks seems to increase CI time
So, can we run lint in parallel with the other tests
BUT can we configure github-actions to STOP all jobs if any 1 job fails.
i.e. if lint fails in 2mins (because of an extra space), stop all the tests
indiVar0508
force-pushed
the
chore_items
branch
5 times, most recently
from
4d11490 to
2e09022
Compare
removed cron job
indiVar0508
force-pushed
the
chore_items
branch
from
2e09022 to
d1b95da
Compare
make lint an independent job for workflow
adding generic_repr method provided by sqla-utils package to be used for attaching a generic __repr__ method to all versioned class. passing primary_keys to generic_repr to be shown along with transaction_id and operation_type
indiVar0508
force-pushed
the
chore_items
branch
3 times, most recently
from
d4a1059 to
130b6e4
Compare
- adding flake8 github actions check for lint - adding flake8 in pyproject.toml - refactor sqlalchemy_history module code according to flake8 - refactor tests directory according to flake8
enable flake8 for pre-commit check
indiVar0508
force-pushed
the
chore_items
branch
from
130b6e4 to
aa211fa
Compare
|
Will add concurrent job halting of jobs if a single job fails, |
2 participants
No description provided.