fix most skipped tests & increase coverage#91
Merged
indiVar0508 merged 9 commits intomasterfrom Oct 13, 2023
Merged
Conversation
indiVar0508
force-pushed
the
indi-due3
branch
3 times, most recently
from
3158cb4 to
b545515
Compare
Pull Request Test Coverage Report for Build 6506267089
💛 - Coveralls |
indiVar0508
force-pushed
the
indi-due3
branch
5 times, most recently
from
dbefed2 to
56b17e7
Compare
indiVar0508
changed the title
indiVar0508
force-pushed
the
indi-due3
branch
6 times, most recently
from
b737583 to
cd377e4
Compare
This was
linked to
issues
Aug 26, 2023
indiVar0508
force-pushed
the
indi-due3
branch
5 times, most recently
from
049fc9e to
cb853fc
Compare
indiVar0508
force-pushed
the
indi-due3
branch
from
cb853fc to
46f961d
Compare
.github/workflows/pages.yml
Outdated
| pip install mkdocs-autorefs==0.4.1 | ||
| pip install mkdocs-awesome-pages-plugin==2.8.0 | ||
| pip install mkdocstrings==0.19.0 | ||
| pip install mkdocstrings['python']==0.19.0 |
There was a problem hiding this comment.
typo in commit message
"docuemntation" -> "documentation"
| article = self.Article() | ||
| blogpost = self.BlogPost() | ||
| textitem = self.TextItem() | ||
| @mark.skipif("True", reason="concrete property is not supported yet") |
Contributor
Author
There was a problem hiding this comment.
kept the tests but excluded the this test as for now we do not support concrete props
indiVar0508
force-pushed
the
indi-due3
branch
from
46f961d to
18c1cd3
Compare
indiVar0508
commented
Sep 26, 2023
| return manager.version_class_map[model] | ||
| except KeyError: | ||
| return model | ||
| return manager.version_class_map.get(model, None) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
indiVar0508
force-pushed
the
indi-due3
branch
from
18c1cd3 to
6957c42
Compare
indiVar0508
force-pushed
the
indi-due3
branch
from
6957c42 to
af36897
Compare
| assert article.versions[0] in reference1.versions[0].cited_by | ||
|
|
||
| def test_multiple_inserts_over_multiple_transactions(self): | ||
| if self.driver == "mysql" and self.connection.dialect.server_version_info < (5, 6): |
There was a problem hiding this comment.
Can we add it in commit message the reason for removing it.
| assert article2.versions[1].operation_type == 1 | ||
| assert article2.versions[0].operation_type == Operation.INSERT | ||
| assert article2.versions[1].operation_type == Operation.UPDATE | ||
| assert article2.versions[1].operation_type != Operation.INSERT |
There was a problem hiding this comment.
Can we remove assert, looks redundant
aditya051293
approved these changes
Oct 13, 2023
there were few tests that were being skipped due to following reasons: 1. schema not being created for oracle so added seperate query in exception block to create these schema 2. update column_reflection test to validate column availability in versioned class 3. removed deprecated tests which are only supported sqla<1.4 4. added reasons for some where we are not yet able to address issue 5. added pragma no cover for except block in tests as we ocasionally hit that in local test but won't happen in CI 6. Removed a check for skipping mysql < 5.6 in a test since we don't test with it and it is EoL anyways.
small move to start using fixtures from pytest as teardown was not working unittest and sometimes a test would fail all subsequent tests started failing, this is due to create_models which once get created are not removed.
splitted fixtures to more atomic fixtures for better structure. added `setup_session` as a dependency fixture for all subclass fixtures
tried to boost coverage for certain tests by doing one of following 1. remove dead code supporting <1.4 2. update configurations to hit certain lines 3. stop skipping tests for mysql < 5.6 as we don't support it 4. added few test these are minor changes which were straight forward to do there are more such scenerio which might take time
indiVar0508
force-pushed
the
indi-due3
branch
from
af36897 to
d10cfe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.