You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fully documented, including docs/history.rst for all changes and docs/rioxarray.rst for new API
For the caching file manager, it closes the file handle from the cache ref. Since there is no cache to close with, I am thinking that the class should keep track of it like the DummyFileManager ref. (ping @TomAugspurger in case you have thoughts on this).
I haven't looked closely at the issue / PR, but just want to note that you may want to be careful to only close the file handle when rioxarray is the one that created it. If you're passed an open file handle then typically the user should be the one to close it. Though like I said, I haven't looked closely so I don't know if that applies here.
you may want to be careful to only close the file handle when rioxarray is the one that created it. If you're passed an open file handle then typically the user should be the one to close it.
This only changes the URIManager used in rioxarray.open_rasterio. If I understand what you are saying, I think this should be safe. Additionally, this PR makes the close method functional as previously it just has pass in there.
snowman2
changed the title
BUG: Close file handle & pass kwargs with lock=False
BUG: Close file handle with lock=False
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/history.rstfor all changes anddocs/rioxarray.rstfor new APIFor the caching file manager, it closes the file handle from the cache ref. Since there is no cache to close with, I am thinking that the class should keep track of it like the DummyFileManager ref. (ping @TomAugspurger in case you have thoughts on this).