fix(lsp): preserve dotted custom root markers#51
Merged
ualtinok merged 1 commit intoMay 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom LSP server
root_markerslose their leading dot during config parsing,so
.oxlintrc.jsonis read asoxlintrc.json. The marker never matches, theworkspace root isn't found, and the custom server starts in the wrong directory.
What changed
crates/aft/src/commands/configure.rs: leading-dot stripping now runs only onextension lists. Root markers are kept as written. Added parser coverage for a
dotted marker.
Why this scope
Stripping the dot is right for extensions (
.tsbecomests) but wrong forfilenames, which are matched literally. The fix stays in the parser and changes
no schema or runtime behavior beyond the marker lookup.
Validation
cargo fmt --checkcargo test -p agent-file-tools(configure parser and lsp inspect tests)Summary by cubic
Fixes LSP config parsing to preserve dotted root markers (e.g., ".oxlintrc.json"). This lets custom servers detect the correct workspace root and start in the right directory.
root_markersandargs.extensionsvia a newrequired_extension_array.Written for commit 95bfe2e. Summary will update on new commits. Review in cubic