BatchJob CRD #2038
Merged
BatchJob CRD #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelvr
force-pushed
the
refactor/batch-job-crd
branch
from
ae73455 to
29ed798
Compare
deliahu
reviewed
Apr 15, 2021
| OperatorLoadBalancerCIDRWhiteList []string `json:"operator_load_balancer_cidr_white_list,omitempty" yaml:"operator_load_balancer_cidr_white_list,omitempty"` | ||
| VPCCIDR *string `json:"vpc_cidr,omitempty" yaml:"vpc_cidr,omitempty"` | ||
| CortexPolicyARN string `json:"cortex_policy_arn" yaml:"cortex_policy_arn"` // this field is not user facing | ||
| AccountID string `json:"account_id" yaml:"account_id"` // this field is not user facing |
Member
There was a problem hiding this comment.
Do you think it would make sense to save the hashed account ID instead of (or in addition to) the account ID?
Collaborator
Author
There was a problem hiding this comment.
Hashing the account ID should be deterministic, right?
miguelvr
commented
Apr 17, 2021
miguelvr
force-pushed
the
refactor/batch-job-crd
branch
2 times, most recently
from
f550382 to
7918e87
Compare
added 25 commits
May 3, 2021 17:03
…dd account id to the managed config
…ke GeneratePreferredNodeAffinities receive a cluster config as an argument
miguelvr
force-pushed
the
refactor/batch-job-crd
branch
from
bf2b1c8 to
5bbb8b3
Compare
vishalbollu
reviewed
May 4, 2021
vishalbollu
reviewed
May 4, 2021
Contributor
vishalbollu
left a comment
vishalbollu
left a comment
There was a problem hiding this comment.
Let's review the GetJobStatus again tomorrow
added 13 commits
May 5, 2021 11:44
# Conflicts: # go.mod # go.sum
vishalbollu
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checklist:
make testandmake lint