Skip to content

Add missing env vars to TaskAPI #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2021
Merged

Add missing env vars to TaskAPI #2144

merged 4 commits into from
May 7, 2021

Conversation

@miguelvr
Copy link
Collaborator

@miguelvr miguelvr commented May 6, 2021

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

RobertLucian
RobertLucian approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miguelvr miguelvr merged commit 46e040c into master May 7, 2021
@miguelvr miguelvr deleted the fix/task-env-vars branch May 7, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

@deliahu deliahu Awaiting requested review from deliahu

@vishalbollu vishalbollu Awaiting requested review from vishalbollu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miguelvr @RobertLucian