feat: Implement Smart Cleanup and Disk Space Optimizer (#125)

cortex/cli.py

@@ -38,8 +38,9 @@
     validate_installation_id,
     ValidationError
 )
-# Import the new Notification Manager
+# Import Notification Manager
 from cortex.notification_manager import NotificationManager
+from cortex.optimizer import CleanupOptimizer
 
 
 class CortexCLI:
@@ -112,10 +113,9 @@
         sys.stdout.write('\r\033[K')
         sys.stdout.flush()
 
-    # --- New Notification Method ---
+    # --- Notification Method ---
     def notify(self, args):
         """Handle notification commands"""
-        # Addressing CodeRabbit feedback: Handle missing subcommand gracefully
         if not args.notify_action:
             self._print_error("Please specify a subcommand (config/enable/disable/dnd/send)")
             return 1
@@ -132,24 +132,21 @@
 
         elif args.notify_action == 'enable':
             mgr.config["enabled"] = True
-            # Addressing CodeRabbit feedback: Ideally should use a public method instead of private _save_config,
-            # but keeping as is for a simple fix (or adding a save method to NotificationManager would be best).
-            mgr._save_config() 
+            mgr.save_config() 
             self._print_success("Notifications enabled")
             return 0
 
         elif args.notify_action == 'disable':
             mgr.config["enabled"] = False
-            mgr._save_config()
-            cx_print("Notifications disabled (Critical alerts will still show)", "warning")
+            mgr.save_config()
+            self._print_success("Notifications disabled (Critical alerts will still show)")
             return 0
 
         elif args.notify_action == 'dnd':
             if not args.start or not args.end:
                 self._print_error("Please provide start and end times (HH:MM)")
                 return 1
 
-            # Addressing CodeRabbit feedback: Add time format validation
             try:
                 datetime.strptime(args.start, "%H:%M")
                 datetime.strptime(args.end, "%H:%M")
@@ -159,7 +156,7 @@
 
             mgr.config["dnd_start"] = args.start
             mgr.config["dnd_end"] = args.end
-            mgr._save_config()
+            mgr.save_config()
             self._print_success(f"DND Window updated: {args.start} - {args.end}")
             return 0
 
@@ -174,7 +171,99 @@
         else:
             self._print_error("Unknown notify command")
             return 1
-    # -------------------------------
+
+
+    def cleanup(self, args):
+        """Run system cleanup optimization"""
+        optimizer = CleanupOptimizer()
+
+        if args.cleanup_action == 'scan':
+            return self._cleanup_scan(optimizer)
+
+        elif args.cleanup_action == 'run':
+            return self._cleanup_run(args, optimizer)
+
+        else:
+            self._print_error("Unknown cleanup action")
+            return 1
+
+    def _cleanup_scan(self, optimizer):
+        self._print_status("🔍", "Scanning for cleanup opportunities...")
+        opportunities = optimizer.scan()
+
+        if not opportunities:
+            self._print_success("No cleanup opportunities found! system is clean.")
+            return 0
+
+        total_bytes = sum(o.size_bytes for o in opportunities)
+        total_mb = total_bytes / (1024 * 1024)
+
+        console.print()
+        cx_header(f"Cleanup Scan Results ({total_mb:.1f} MB Reclaimable)")
+
+        from rich.table import Table
+        table = Table(box=None)
+        table.add_column("Type", style="cyan")
+        table.add_column("Description")
+        table.add_column("Size", justify="right", style="green")
+
+        for opp in opportunities:
+            size_mb = opp.size_bytes / (1024 * 1024)
+            table.add_row(
+                opp.type.replace('_', ' ').title(),
+                opp.description,
+                f"{size_mb:.1f} MB"
+            )
+
+        console.print(table)
+        console.print()
+        console.print("[dim]Run 'cortex cleanup run' to clean these items.[/dim]")
+        return 0
+
+    def _cleanup_run(self, args, optimizer):
+        safe_mode = not args.force
+
+        self._print_status("🔍", "Preparing cleanup plan...")
+        commands = optimizer.get_cleanup_plan()
+
+        if not commands:
+            self._print_success("Nothing to clean!")
+            return 0
+
+        console.print("[bold]Proposed Cleanup Operations:[/bold]")
+        for i, cmd in enumerate(commands, 1):
+            console.print(f"  {i}. {cmd}")
+
+        if getattr(args, 'dry_run', False):
+                console.print("\n[dim](Dry run mode - no changes made)[/dim]")
+                return 0
+
+        if not args.yes:
+            if not safe_mode:
+                console.print("\n[bold red]WARNING: Running in FORCE mode (no backups)[/bold red]")
+
+            confirm = input("\nProceed with cleanup? (y/n): ")
+            if confirm.lower() != 'y':
+                print("Operation cancelled.")
+                return 0
+
+        # Use InstallationCoordinator for execution
+        def progress_callback(current, total, step):
+            print(f"[{current}/{total}] {step.description}")
+
+        coordinator = InstallationCoordinator(
+            commands=commands,
+            descriptions=[f"Cleanup Step {i+1}" for i in range(len(commands))],
+            progress_callback=progress_callback
+        )
+
+        result = coordinator.execute()
+        if result.success:
+            self._print_success("Cleanup completed successfully!")
+            return 0
+        else:
+            self._print_error("Cleanup encountered errors.")
+            return 1
 
     def install(self, software: str, execute: bool = False, dry_run: bool = False):
         # Validate input first
@@ -543,7 +632,7 @@
     table.add_row("install <pkg>", "Install software")
     table.add_row("history", "View history")
     table.add_row("rollback <id>", "Undo installation")
-    table.add_row("notify", "Manage desktop notifications")  # Added this line
+    table.add_row("notify", "Manage desktop notifications")
 
     console.print(table)
     console.print()
@@ -598,7 +687,7 @@
     edit_pref_parser.add_argument('key', nargs='?')
     edit_pref_parser.add_argument('value', nargs='?')
 
-    # --- New Notify Command ---
+    # --- Notify Command ---
     notify_parser = subparsers.add_parser('notify', help='Manage desktop notifications')
     notify_subs = notify_parser.add_subparsers(dest='notify_action', help='Notify actions')
 
@@ -615,6 +704,19 @@
     send_parser.add_argument('--title', default='Cortex Notification')
     send_parser.add_argument('--level', choices=['low', 'normal', 'critical'], default='normal')
     send_parser.add_argument('--actions', nargs='*', help='Action buttons')
+
+
+    # --- Cleanup Command ---
+    cleanup_parser = subparsers.add_parser('cleanup', help='Optimize disk space')
+    cleanup_subs = cleanup_parser.add_subparsers(dest='cleanup_action', help='Cleanup actions')
+
+    cleanup_subs.add_parser('scan', help='Scan for cleanable items')
+
+    run_parser = cleanup_subs.add_parser('run', help='Execute cleanup')
+    run_parser.add_argument('--safe', action='store_true', default=True, help='Run safely (with backups)')
+    run_parser.add_argument('--force', action='store_true', help='Force cleanup (no backups)')
+    run_parser.add_argument('--yes', '-y', action='store_true', help='Skip confirmation')
+    run_parser.add_argument('--dry-run', action='store_true', help='Show proposed changes without executing')
     # --------------------------
 
     args = parser.parse_args()
@@ -642,9 +744,12 @@
             return cli.check_pref(key=args.key)
         elif args.command == 'edit-pref':
             return cli.edit_pref(action=args.action, key=args.key, value=args.value)
-        # Handle the new notify command
         elif args.command == 'notify':
             return cli.notify(args)
+        # Handle new command
+
+        elif args.command == 'cleanup':
+            return cli.cleanup(args)
         else:
             parser.print_help()
             return 1