Skip to content

Conversation

@Anshgrover23
Copy link
Collaborator

@Anshgrover23 Anshgrover23 commented Jan 18, 2026

Related Issue

Closes #

Summary

AI Disclosure

  • No AI used
  • AI/IDE/Agents used (please describe below)

Checklist

  • PR title follows format: type(scope): description or [scope] description
  • Tests pass (pytest tests/)
  • MVP label added if closing MVP issue
  • Update "Cortex -h" (if needed)

Summary by CodeRabbit

  • Chores

    • Updated CI workflows to install project extras (dev/security) via editable package install instead of installing individual tooling.
    • Removed a legacy automation workflow.
  • Refactor

    • Reformatted SQL and string/print literals across the codebase for consistent styling; no behavioral changes.
    • Cleaned up test data formatting for clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 18, 2026 07:27
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Consolidates CI dependency installation to editable project extras (dev/security) across workflows and reformats many SQL and print/string literals for consistency; no behavioral or API changes.

Changes

Cohort / File(s) Summary
GitHub Workflows
.github/workflows/autofix.yml, .github/workflows/automation.yml, .github/workflows/ci.yml
Replaced per-tool installs (ruff, black, isort, mypy, bandit, safety, build, twine) with editable installs of project extras (e.g., pip install -e ".[dev]", pip install -e ".[security]"); one workflow (automation.yml) was removed.
SQL String Formatting
cortex/context_memory.py, cortex/graceful_degradation.py, cortex/installation_history.py, cortex/kernel_features/kv_cache_manager.py, cortex/kernel_features/model_lifecycle.py, cortex/role_manager.py, cortex/semantic_cache.py, cortex/transaction_history.py, daemon/scripts/setup_daemon.py, tests/test_context_memory.py, tests/test_role_management.py
Collapsed or reformatted multi-line SQL literals into single triple-quoted strings or consolidated calls; SQL content, schema, and execution semantics unchanged.
Print / String Formatting
cortex/first_run_wizard.py, cortex/licensing.py, cortex/uninstall_impact.py
Converted multi-line print blocks to single print() calls and consolidated f-strings or adjacent string literals; message content and control flow preserved.
Test Fixture Formatting
tests/test_shell_env_analyzer.py
Collapsed multi-line write_text fixtures into single triple-quoted strings; test behavior unchanged.

Sequence Diagram(s)

(silently skipped — changes are formatting and CI dependency consolidation without new multi-component control flow)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

MVP

Suggested reviewers

  • mikejmorgan-ai
  • Suyashd999

Poem

🐰
Hopping through code with a twitchy nose,
I tidy SQL rows and CI flows,
Strings snugged tight, extras installed,
No logic changed — just neatness called,
A cheerful patch where clean code grows.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description follows the template structure but is largely incomplete: the Related Issue section is unfilled (marked REQUIRED in template), and the Summary section lacks any explanation of what the PR does. Add the related issue number to the 'Closes #' line and provide a meaningful summary explaining the dependency installation changes made across the workflows.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: unifying dependency installation steps across multiple GitHub workflows (.github/workflows/) from individual tool installations to editable package installs with extras.
Docstring Coverage ✅ Passed Docstring coverage is 81.48% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes dependency installation across GitHub Actions workflows by consolidating tool installations into unified dependency groups defined in the project's setup configuration.

Changes:

  • Replaced individual tool installations with package extras groups ([dev] and [security])
  • Standardized step naming from specific tool names to generic "Install dependencies"
  • Removed redundant package installation step in security workflow

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ci.yml Updated lint, security, and build jobs to use consolidated dependency groups instead of individual tool installations
.github/workflows/automation.yml Replaced specific linting and security tool installations with package extras groups
.github/workflows/autofix.yml Changed formatter installation to use the [dev] extras group

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

Copy link
Collaborator

@divanshu-go divanshu-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anshgrover23 Anshgrover23 merged commit b263bb9 into main Jan 18, 2026
18 checks passed
@Anshgrover23 Anshgrover23 deleted the fix/lint branch January 18, 2026 07:40
KrishnaShuk pushed a commit to KrishnaShuk/cortex that referenced this pull request Jan 18, 2026
…nux#640)

* chore: unify dependency installation steps across workflows

* [autofix.ci] apply automated fixes

* chore: remove obsolete Cortex automation workflow file

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants