make rulerAPIPath configurable #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janwillies
force-pushed
the
configure-rules-endpoint
branch
from
d4dddf4 to
9dcf1d0
Compare
Author
|
could you please take a look @friedrichg? |
friedrichg
requested changes
Nov 1, 2023
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
I don't see why not. Just the yaml needs to be like the rest.
Co-authored-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Jan Willies <jan.willies@accenture.com>
janwillies
force-pushed
the
configure-rules-endpoint
branch
from
e8348ad to
33c3017
Compare
Author
|
whoops, fixed now |
friedrichg
approved these changes
Nov 1, 2023
Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com>
Member
|
@janwillies can you accept/merge janwillies#1 ? |
Include flags for ruler command
friedrichg
added a commit
that referenced
this pull request
May 9, 2024
* make rulerAPIPath configurable Co-authored-by: Friedrich Gonzalez <friedrichg@gmail.com> Signed-off-by: Jan Willies <jan.willies@accenture.com> * Include flags for ruler command Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> --------- Signed-off-by: Jan Willies <jan.willies@accenture.com> Signed-off-by: Friedrich Gonzalez <friedrichg@gmail.com> Co-authored-by: Friedrich Gonzalez <friedrichg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ruler api path is hardcoded in cortex-tools. In some deployments the ruler api is available on a different path though. This PR makes the
rulerAPIPathconfigurable