Skip to content

Integration tests should run compactor instead of disabling bucket-index #7272

@friedrichg

Description

@friedrichg

Summary

After PR #7259 enabled bucket-index by default, several integration tests were updated to explicitly disable bucket-index rather than properly configuring a compactor to create the bucket index. This is a workaround that should be fixed.

Background

PR #7259 changed -blocks-storage.bucket-store.bucket-index.enabled to default to true. Some integration tests that do not run a compactor needed to disable this feature to continue working.

Files Affected

The following test files contain // TODO: run a compactor here instead of disabling the bucket-index:

  • integration/backward_compatibility_test.go
  • integration/native_histogram_test.go
  • integration/querier_test.go (4 locations)
  • integration/query_frontend_test.go
  • integration/query_fuzz_test.go (4 locations)

Proposed Fix

For each affected test:

  1. Start a compactor service with appropriate configuration
  2. Wait for the compactor to create the bucket index
  3. Remove the -blocks-storage.bucket-store.bucket-index.enabled=false flag

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions