-
Notifications
You must be signed in to change notification settings - Fork 847
Open
Labels
component/compactortype/choreSomething that needs to be done; not a bug or a featureSomething that needs to be done; not a bug or a feature
Description
Summary
After PR #7259 enabled bucket-index by default, several integration tests were updated to explicitly disable bucket-index rather than properly configuring a compactor to create the bucket index. This is a workaround that should be fixed.
Background
PR #7259 changed -blocks-storage.bucket-store.bucket-index.enabled to default to true. Some integration tests that do not run a compactor needed to disable this feature to continue working.
Files Affected
The following test files contain // TODO: run a compactor here instead of disabling the bucket-index:
-
integration/backward_compatibility_test.go -
integration/native_histogram_test.go -
integration/querier_test.go(4 locations) -
integration/query_frontend_test.go -
integration/query_fuzz_test.go(4 locations)
Proposed Fix
For each affected test:
- Start a compactor service with appropriate configuration
- Wait for the compactor to create the bucket index
- Remove the
-blocks-storage.bucket-store.bucket-index.enabled=falseflag
Related
- Introduced in: c3d066c
- Original issue: Take bucket index out of experimental and make it enabled by default #7258
- Original PR: bucket-index-enabled by default #7259
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
component/compactortype/choreSomething that needs to be done; not a bug or a featureSomething that needs to be done; not a bug or a feature