Make sure the HA tracker only handles valid keys #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/cc @cstyan - WDYT? |
tomwilkie
approved these changes
Sep 18, 2019
Contributor
tomwilkie
left a comment
tomwilkie
left a comment
There was a problem hiding this comment.
Assuming Callum is happy with it.
cstyan
approved these changes
Sep 18, 2019
pkg/distributor/ha_tracker.go
Outdated
Contributor
There was a problem hiding this comment.
Can we leave a comment here or somewhere nearby like The prefix has already been stripped, so a valid key would look like cluster/replica, and a key without a / such as ring would be invalid.
If the ring and the HA tracker share the same prefix then we will end up handling invalid keys. Fixes cortexproject#1652 and cortexproject#1628 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
fix-ha-tracker-wrong-keys
branch
from
4b097cf to
4922f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ring and the HA tracker share the same prefix then we will end up
handling invalid keys.
Fixes #1652 and #1628
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com