Skip to content

Conversation

@joe-elliott
Copy link
Contributor

What this PR does:

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Copy link
Contributor Author

I believe our per operation sampling rule issues could be resolved with this update.

cc @gouthamve @jtlisi

@gouthamve
Copy link
Contributor

This shouldn't require a changelog entry. LGTM otherwise

This reverts commit 04ec7bc.

Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott
Copy link
Contributor Author

Changelog entry reverted.

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this - I forgot to check when that fix had been released.

@bboreham bboreham merged commit c8d4f22 into cortexproject:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants