Make each DNS provider register a diff metric #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
pracucci
reviewed
Mar 20, 2020
pstibrany
approved these changes
Mar 20, 2020
pracucci
reviewed
Mar 20, 2020
pkg/chunk/cache/memcached_client.go
Outdated
Contributor
There was a problem hiding this comment.
I would just suggest to rename registerer to dnsProviderRegisterer to avoid in the future people will erroneously use the replaced registerer to register other metrics.
gouthamve
force-pushed
the
fix-multi-register
branch
from
a47ce14 to
ad776b7
Compare
bboreham
approved these changes
Mar 20, 2020
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Generally looks OK but I have questions about the comments in the test.
Also incorporate review feedback. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
fix-multi-register
branch
from
ad776b7 to
2eda98e
Compare
Contributor
Author
|
Sorry for the stale comments (copied the test from the blocks storage test). Clarified them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com
Which issue(s) this PR fixes:
Fixes #2302
Checklist