Fix multiple registrations with multi schema #2309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It stops the crashing, but caches no longer work - just get |
gouthamve
force-pushed
the
fix-multi-register-again
branch
3 times, most recently
from
5e1645c to
c7d5c70
Compare
pracucci
approved these changes
Mar 20, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
The new design is way better! LGTM, but I have a concern about the config changes in the integration tests. May you take a look?
Move all the caches up and don't create new ones for each schema. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
fix-multi-register-again
branch
from
c7d5c70 to
8614b82
Compare
pstibrany
reviewed
Mar 21, 2020
Comment on lines
115
to
+119
| // Cache is shared by multiple stores, which means they will try and Stop | ||
| // it more than once. Wrap in a StopOnce to prevent this. | ||
| tieredCache = cache.StopOnce(tieredCache) | ||
| indexReadCache = cache.StopOnce(indexReadCache) | ||
| chunksCache = cache.StopOnce(chunksCache) | ||
| writeDedupeCache = cache.StopOnce(writeDedupeCache) |
Contributor
There was a problem hiding this comment.
This is a strange design... if store isn't initializing the cache, it should not stop it. Cache should only be stopped after the last store stops using it, not by first store. Something to look at in the future I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2302
@bboreham Can you test if this actually fixes the issue?