Skip to content

Conversation

@bboreham
Copy link
Contributor

@bboreham bboreham commented Mar 4, 2021

User did not understand that the page on WAL storage does not apply to blocks.

Ref https://cloud-native.slack.com/archives/CCYDASBLP/p1614849933207700?thread_ts=1614828385.205500&cid=CCYDASBLP

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a fix)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise linking doesn't work:

Suggested change
_This documentation refers to Cortex chunks storage engine. To understand Blocks storage please go [here](../blocks-storage)._
_This documentation refers to Cortex chunks storage engine. To understand Blocks storage please go [here](../blocks-storage/_index.md)._

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@pracucci pracucci merged commit f25e0b5 into master Mar 4, 2021
roystchiang pushed a commit to roystchiang/cortex that referenced this pull request Apr 6, 2022
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@friedrichg friedrichg deleted the clarify-wal-doc branch February 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants