Fix docker port parsing in integration tests #4103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Apr 22, 2021
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
Looks like you were right :)
Contributor
|
Thanks a lot for this! |
Closed
pstibrany
pushed a commit
to pstibrany/cortex
that referenced
this pull request
Apr 27, 2021
* Fix docker port parsing in integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
pushed a commit
to pstibrany/cortex
that referenced
this pull request
Apr 27, 2021
* Fix docker port parsing in integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
added a commit
that referenced
this pull request
Apr 27, 2021
pstibrany
added a commit
that referenced
this pull request
Apr 27, 2021
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
* Fix docker port parsing in integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter Signed-off-by: Marco Pracucci <marco@pracucci.com>
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
…) (cortexproject/cortex#4131) * Fix docker port parsing in integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Integration tests are failing with the error:
Looking at the output, I believe GitHub actions enabled IPv6 on the runners and so we're both getting IPv4 and IPv6 port mapping, which is breaking the parsing.
If my hypothesis is correct, this PR should fix it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]