Adding unit test for parsing errors on frontend split queries #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariana Franco <marfram@amazon.com>
Signed-off-by: Mariana Franco <marfram@amazon.com>
marianafranco
force-pushed
the
qfe-unittest
branch
from
23a43b4 to
39a3956
Compare
alvinlin123
reviewed
Oct 1, 2021
| } | ||
| } | ||
|
|
||
| func Test_evaluateAtModifier_Error(t *testing.T) { |
Contributor
There was a problem hiding this comment.
My opinion is that we should merge this test into Test_evaluateAtModifier. We can extend Test_evaluateAtModifier's parameter to have an optional expectedErrorCode, then go from there.
The reason I think so is because this function seems quite duplicated to Test_evaluateAtModifier. It's also easier to discover what test cases are there for at-modifiers if we group them into one function.
What do you think?
Contributor
Author
There was a problem hiding this comment.
Makes sense! I pushed a new commit with this change.
Signed-off-by: Mariana Franco <marfram@amazon.com>
marianafranco
force-pushed
the
qfe-unittest
branch
from
c9bdf77 to
e01d967
Compare
alvinlin123
approved these changes
Oct 3, 2021
Contributor
alvinlin123
left a comment
alvinlin123
left a comment
There was a problem hiding this comment.
LGTM, thanks for the new tests!
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
…project#4504) * Adding unit test for parsing errors on frontend split queries Signed-off-by: Mariana Franco <marfram@amazon.com> * Fix lint errors Signed-off-by: Mariana Franco <marfram@amazon.com> * Merging error test cases with success ones Signed-off-by: Mariana Franco <marfram@amazon.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…project#4504) * Adding unit test for parsing errors on frontend split queries Signed-off-by: Mariana Franco <marfram@amazon.com> * Fix lint errors Signed-off-by: Mariana Franco <marfram@amazon.com> * Merging error test cases with success ones Signed-off-by: Mariana Franco <marfram@amazon.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mariana Franco marfram@amazon.com
What this PR does:
Adds extra unit tests for the following fix: #4488
This will help to make sure 400s don't turn again to 500s.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]