Skip to content

Making the QueryRequest Releasable #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

Making the QueryRequest Releasable #7094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions integration/grpc_server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ type mockGprcServer struct {
func (m mockGprcServer) QueryStream(req *ingester_client.QueryRequest, streamServer ingester_client.Ingester_QueryStreamServer) error {
md, _ := metadata.FromIncomingContext(streamServer.Context())
i, _ := strconv.Atoi(md["i"][0])
defer req.Free()
return streamServer.Send(createStreamResponse(i))
}

Expand Down Expand Up @@ -72,7 +73,7 @@ func (m mockGprcServer) Push(ctx context.Context, request *cortexpb.WriteRequest
return &cortexpb.WriteResponse{}, nil
}

func run(t *testing.T, cfg server.Config, register func(s *grpc.Server), validate func(t *testing.T, con *grpc.ClientConn)) {
func run(t testing.TB, cfg server.Config, register func(s *grpc.Server), validate func(t testing.TB, con *grpc.ClientConn)) {
savedRegistry := prometheus.DefaultRegisterer
prometheus.DefaultRegisterer = prometheus.NewRegistry()
defer func() {
Expand Down Expand Up @@ -107,6 +108,7 @@ func run(t *testing.T, cfg server.Config, register func(s *grpc.Server), validat

clientConfig := grpcclient.Config{}
clientConfig.RegisterFlags(flag.NewFlagSet("fake", flag.ContinueOnError))
clientConfig.GRPCCompression = "zstd"

dialOptions, err := clientConfig.DialOption(nil, nil)
assert.NoError(t, err)
Expand All @@ -117,22 +119,44 @@ func run(t *testing.T, cfg server.Config, register func(s *grpc.Server), validat
validate(t, conn)
}

func BenchmarkGrpcCalls(b *testing.B) {
cfg := server.Config{}
(&cfg).RegisterFlags(flag.NewFlagSet("fake", flag.ContinueOnError))
register := func(s *grpc.Server) {
d := &mockGprcServer{}
ingester_client.RegisterIngesterServer(s, d)
}
run(b, cfg, register, func(t testing.TB, conn *grpc.ClientConn) {
ctx := context.Background()
ctx = metadata.NewOutgoingContext(ctx, metadata.MD{"i": []string{strconv.Itoa(0)}})
client := ingester_client.NewIngesterClient(conn)
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
s, err := client.QueryStream(ctx, &ingester_client.QueryRequest{})
require.NoError(t, err)
_, err = s.Recv()
require.NoError(t, err)
}
})
}

func TestConcurrentGrpcCalls(t *testing.T) {
cfg := server.Config{}
(&cfg).RegisterFlags(flag.NewFlagSet("fake", flag.ContinueOnError))

tc := map[string]struct {
cfg server.Config
register func(s *grpc.Server)
validate func(t *testing.T, con *grpc.ClientConn)
validate func(t testing.TB, con *grpc.ClientConn)
}{
"distributor": {
cfg: cfg,
register: func(s *grpc.Server) {
d := &mockGprcServer{}
distributorpb.RegisterDistributorServer(s, d)
},
validate: func(t *testing.T, conn *grpc.ClientConn) {
validate: func(t testing.TB, conn *grpc.ClientConn) {
client := distributorpb.NewDistributorClient(conn)
wg := sync.WaitGroup{}
n := 10000
Expand All @@ -156,7 +180,7 @@ func TestConcurrentGrpcCalls(t *testing.T) {
d := &mockGprcServer{}
ingester_client.RegisterIngesterServer(s, d)
},
validate: func(t *testing.T, conn *grpc.ClientConn) {
validate: func(t testing.TB, conn *grpc.ClientConn) {
ctx := context.Background()
client := ingester_client.NewIngesterClient(conn)
wg := sync.WaitGroup{}
Expand Down Expand Up @@ -188,7 +212,7 @@ func TestConcurrentGrpcCalls(t *testing.T) {
d := &mockGprcServer{}
ingester_client.RegisterIngesterServer(s, d)
},
validate: func(t *testing.T, conn *grpc.ClientConn) {
validate: func(t testing.TB, conn *grpc.ClientConn) {
client := ingester_client.NewIngesterClient(conn)
wg := sync.WaitGroup{}
n := 10000
Expand Down
Loading
Loading