Skip to content

Conversation

@friedrichg
Copy link
Member

What this PR does: Move microservices_mode tests to separate thread in GitHub Actions

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
@friedrichg friedrichg force-pushed the split-out-microservices-mode branch from 5fa4361 to fade6c3 Compare February 9, 2026 22:44
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
@friedrichg friedrichg requested a review from yeya24 February 10, 2026 01:35
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what this PR is for?

Tbh I feel those test cases are quite flaky and it is very complicated right now. I wonder if we really need to test every combination of index cache backend, chunk cache backend and bucket index enabled or not.

@friedrichg
Copy link
Member Author

friedrichg commented Feb 10, 2026

@yeya24
Before
https://github.com/cortexproject/cortex/actions/runs/21836985484/usage
Screenshot 2026-02-09 at 10 54 33 PM

After
https://github.com/cortexproject/cortex/actions/runs/21846216279/usage
This PRs creates a separate machine that only runs this TestQuerierWithBlocksStorageRunningInMicroservicesMode

Screenshot 2026-02-09 at 10 55 50 PM

I didn't change them in any way. Just moved them to a separate place to be run separately

@friedrichg
Copy link
Member Author

Tbh I feel those test cases are quite flaky and it is very complicated right now. I wonder if we really need to test every combination of index cache backend, chunk cache backend and bucket index enabled or not.

We should remove tests without bucket index enabled. That is always a bad idea. Let's do that in separate PR

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 10, 2026
@friedrichg friedrichg merged commit 18ff25d into master Feb 10, 2026
59 of 60 checks passed
@friedrichg friedrichg deleted the split-out-microservices-mode branch February 10, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size/XXL type/tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants