PRW2: Fix index out-of-range panic#7299
Open
SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
Open
PRW2: Fix index out-of-range panic#7299SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
SungJin1212 wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a reused
TimeSeriesV2object contains leftover metadata values (e.g.,UnitRef: 99) from a previous large request, and the new incoming request omits metadata,Unmarshalskips overwriting those fields. If the new request has a smaller Symbols table, accessingreq.Symbols[v2Ts.Metadata.UnitRef]causes an immediate index out of range panic.This PR resets metadata before returning to the
sync.Pool. The test verifies that subsequent requests with omitted metadata do not cause a panic.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]