bugfix sort after merging histogram metrics#7380
Open
Shvejan wants to merge 1 commit intocortexproject:masterfrom
Open
bugfix sort after merging histogram metrics#7380Shvejan wants to merge 1 commit intocortexproject:masterfrom
Shvejan wants to merge 1 commit intocortexproject:masterfrom
Conversation
Signed-off-by: Shvejan Mutheboyina <shvejan@amazon.com>
SungJin1212
reviewed
Mar 27, 2026
| * [ENHANCEMENT] Tenant Federation: Add a local cache to regex resolver. #7363 | ||
| * [ENHANCEMENT] Query Scheduler: Add `cortex_query_scheduler_tracked_requests` metric to track the current number of requests held by the scheduler. #7355 | ||
| * [BUGFIX] Fix nil when ingester_query_max_attempts > 1. #7369 | ||
| * [BUGFIX] Metrics Helper: Fix non-deterministic bucket order in merged histograms by sorting buckets after map iteration, matching Prometheus client library behavior. #7379 |
Member
There was a problem hiding this comment.
Suggested change
| * [BUGFIX] Metrics Helper: Fix non-deterministic bucket order in merged histograms by sorting buckets after map iteration, matching Prometheus client library behavior. #7379 | |
| * [BUGFIX] Metrics Helper: Fix non-deterministic bucket order in merged histograms by sorting buckets after map iteration, matching Prometheus client library behavior. #7380 |
Can you fix a PR number?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add
sort.Slice()to sort buckets byUpperBoundin ascending order after building from the map. This matches the Prometheus client library's approach:Which issue(s) this PR fixes:
Fixes #7379
Checklist
CHANGELOG.mdupdated - the order of entries should be[BUGFIX]