Memberlist cas error code false positive#7408
Merged
SungJin1212 merged 2 commits intocortexproject:masterfrom Apr 10, 2026
Merged
Memberlist cas error code false positive#7408SungJin1212 merged 2 commits intocortexproject:masterfrom
SungJin1212 merged 2 commits intocortexproject:masterfrom
Conversation
963e067 to
52d8f76
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
52d8f76 to
1dea7bd
Compare
53f5194 to
ebae696
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCasErrorCodeused a direct type assertion to detectIsOperationAborted(), which fails when the error is wrapped by memberlist'strySingleCas:This caused
ReplicasNotMatchError(normal HA deduplication) to be reported as status_code="500" incortex_kv_request_duration_secondswhen usingmemberlistas the HA tracker KV store, triggering false-positiveCortexKVStoreFailurealerts.Note: consul and etcd are unaffected because they return the callback error directly without wrapping (
return err), so the direct type assertion worked correctly for those backends.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]