Disable bucket index cache if TTL is 0#7446
Merged
danielblando merged 5 commits intocortexproject:masterfrom Apr 29, 2026
Merged
Disable bucket index cache if TTL is 0#7446danielblando merged 5 commits intocortexproject:masterfrom
danielblando merged 5 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Wilson La <wilsnlaa@amazon.com>
Signed-off-by: Wilson La <wilsnlaa@amazon.com>
Wassup789
force-pushed
the
disable-bucket-index-cache
branch
from
294f936 to
22c26e5
Compare
dosubot
Bot
added
component/store-gateway
type/chore
friedrichg
reviewed
Apr 23, 2026
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
LGTM
@Wassup789 could we add a unit/integration test?
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Wilson La <wilsnlaa@amazon.com>
Signed-off-by: Wilson La <git@wilsonla.ca>
Contributor
Author
|
Thanks @friedrichg, added unit tests. |
Contributor
|
LGTM |
danielblando
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
When querier / store-gateway have the bucket index TTL set to zero, we are still retrieving the index via the cache.
This PR disables the cache of the bucket index when the TTL is set to zero.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags