feat(ingester): Add "source" pprof label to all query methods#7494
Merged
danielblando merged 2 commits intocortexproject:masterfrom May 8, 2026
Merged
Conversation
dosubot
Bot
added
component/ingester
type/feature
type/observability
Add GetSource() to requestmeta and use it as a pprof label in all ingester pprof.Do sites (QueryStream, LabelValues, LabelNames, MetricsForLabelMatchers, MetricsMetadata, QueryExemplars). The ruler already sets source="ruler" via ContextWithRequestSource; queries without a source show as "unknown". Usage: go tool pprof -tagfocus="source:ruler" profile.pb.gz go tool pprof -tagfocus="source:unknown" profile.pb.gz Signed-off-by: Daniel Blando <ddeluigg@amazon.com>
danielblando
force-pushed
the
feat/pprof-caller-label
branch
from
8bce4b8 to
b5889c0
Compare
yeya24
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GetSource() to requestmeta and use it as a pprof label in all ingester pprof.Do sites (QueryStream, LabelValues, LabelNames, MetricsForLabelMatchers, MetricsMetadata, QueryExemplars). The ruler already sets source="ruler" via ContextWithRequestSource; queries without a source show as "unknown".
Usage:
go tool pprof -tagfocus="source:ruler" profile.pb.gz
go tool pprof -tagfocus="source:unknown" profile.pb.gz
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags