fix: 25 bugs — threading, MCP locks, scratch_that, Ollama model, SOAP QA, security#4
Merged
Merged
Conversation
… QA, security Critical: - Fix scratch_that() completely broken (tags never applied to text chunks) - Fix MCP HealthMonitor sleeping while holding lock (blocked all MCP ops 8s) High: - Fix MCP execute_tool holding lock during 30s blocking I/O - Fix MCP send_request discarding orphaned responses (per-request queues) - Fix unguarded json.loads in RAG vector stores (6 locations) - Fix autosave reading Tkinter widgets from background thread - Fix Ollama ignoring user-selected model in agent calls (always defaulted to llama3) Medium: - Fix SOAP QA/ICD validation not running via Record tab code path - Fix conversation_history thread safety (add missing lock) - Fix notification_manager: unsynchronized history, thread never stops, fade crashes - Fix MCP rate limiter sleeping while holding lock - Fix SQLiteCacheProvider leaking cross-thread connections - Fix StreamingResults animation crash on widget destruction - Fix PHI transcript/patient data logged in plaintext (bypass structured logger) - Fix key file TOCTOU (written with default perms before chmod) - Fix TTS NamedTemporaryFile breaking playback on Windows - Fix periodic_analysis string join operator precedence Low: - Fix Database instance leaks in dialogs (add db= param + warning) - Fix TTS _play_audio_async silently swallowing exceptions - Fix help dialog, status timer, RSVP dialog lifecycle issues Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive 5-agent code review found and fixed 25 bugs across 30 files:
scratch_that()completely non-functional (tags never applied); MCP HealthMonitor blocked all operations for up to 8s while holding lockKey fixes
tag_add()was never called after text insertllama3regardless of user selection —call_ollama()didn't accept a model parametercompare_medicationswas only wired in the Generate tab code pathTest plan
🤖 Generated with Claude Code