Improve startup speed with lazy version loading (v0.9.4) #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace eager importlib.metadata import with lazy get_version() function. This avoids ~88ms overhead on every CLI invocation since importlib.metadata is only loaded when the version string is actually needed (e.g., --version flag, remote deployment, JSON output). Changes: - Add get_version() function in config.py that caches the version - Create _LazyVersion class in cli.py for deferred --version lookup - Update all VERSION imports to use get_version() instead
Replace eager importlib.metadata import with lazy get_version() function. Saves ~88ms on every CLI invocation by only loading version when needed.
The _LazyVersion class approach breaks because argparse calls various string methods (splitlines, __contains__) on the version. Using a custom Action class that only loads the version when --version is invoked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
importlib.metadataimport with lazyget_version()function--versionflag, remote deployment, JSON output)Changes
get_version()function inconfig.pythat caches the version_LazyVersionclass incli.pyfor deferred--versionlookupVERSIONimports to useget_version()insteadTest plan
shannot --versionstill worksshannot statusshows correct version