forked from CorvidLabs/.github
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Moved from CorvidLabs/corvid-agent#192
Summary
Two internal packages live in packages/ but aren't published or consumed anywhere in the codebase.
Packages
packages/env (@corvid-agent/env)
- Type-safe environment variable parser for TypeScript
- Has full package.json with
prepublishOnly, tsup build, vitest tests, CI workflow - Repository URL points to
https://github.com/corvid-agent/env.git - NOT currently imported anywhere in the main corvid-agent codebase
- Has its own
.github/workflows/ci.yml
packages/result (@corvidlabs/result)
- Type-safe Result<T, E> type inspired by Rust/Swift
- Same setup: tsup, vitest, CI workflow, prepublishOnly
- Repository URL points to
https://github.com/CorvidLabs/result.git - NOT currently imported anywhere in the main corvid-agent codebase
Questions to resolve
- Why aren't these published to GitHub Packages / npm? They have CI workflows and prepublishOnly scripts ready.
- Should they be published under
@corvidlabsscope on GitHub Packages using GitHub Actions? - Are they intended to be used by corvid-agent (currently unused) or are they standalone libraries for the ecosystem?
- Inconsistent scoping: env uses
@corvid-agent/scope, result uses@corvidlabs/scope. Should be unified. - The
ts-algochatpackage IS on npm/GitHub but uses@corvidlabs/scope. The env package points togithub.com/corvid-agent/(different org?).
Recommended actions
- Decide on a single npm scope (
@corvidlabsprobably, to match ts-algochat) - Set up GitHub Actions to publish to GitHub Packages on release tags
- If these packages are meant for corvid-agent, actually integrate them (replace hand-rolled env parsing with
@corvid-agent/env, use Result type where appropriate) - If they're standalone ecosystem libs, consider moving them to their own repos (the repo URLs already suggest this intent) and removing from the monorepo
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels