Open
Conversation
|
I vote for this fix |
Author
|
That is very curious. The current osht behavior puts attributes in a tag
that shouldn't have them -- I don't even understand how any system can read
them. This PR doesn't split tests, it simply puts the summary in a single
test suite. Each test is written as a separate test case as per current
behavior -- nothing was changed there.
Perhaps the problem is that your internal system _didn't_ recognize any
test case at all before because of the invalid XML layout?
…--
Daniel C. Sobral
On Tue, Mar 3, 2020 at 6:23 AM Michael Andrews ***@***.***> wrote:
I actually had an internal system reject my JUnit XML because this PR puts
each test in a separate test suite. Maybe there should be an option for
that instead of making it the default.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8?email_source=notifications&email_token=AABCOF7DE25AAHYORZDWV7TRFUADHA5CNFSM4H4UKI42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENTOV7Q#issuecomment-593947390>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABCOF4IMVZZHOR7ZTHDZ63RFUADHANCNFSM4H4UKI4Q>
.
|
|
I had the same issue in CircleCI. Pasting in the code from this PR fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Researching into this, I was able to confirm the current format is incorrect. In fact, I couldn't even see the results in the browser I used, until I applied the fix. Looking at one of the documented schemas I found, I could see the attributes being used corresponded to the
testcasetag instead of thetestcasestag, so I fixed it by introducing a newtestcasestag and renaming the existing one.