Fix the result of ChaCha20/Poly1305.#104
Merged
OR13 merged 1 commit intocose-wg:masterfrom Mar 13, 2024
Merged
Conversation
OR13
approved these changes
Mar 2, 2024
Contributor
|
This pull request will be merged in 1 week per: https://mailarchive.ietf.org/arch/msg/cose/-pFDD00aNpXVSQGFChppBymQi-w/ Unless there are objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of ciphertext in the ChaCha20/Poly1035 example seems to be wrong. Can you please tell me the code that generated this example?
Anyway, I'll send you the result I think is correct as this PR.