feat: add hint convert modal #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shinyu0430
commented
Sep 22, 2024
shinyu0430
commented
- When the user clicks "Convert," show a pop-up hint modal displaying the current delimiter, the new delimiter, and the amount of the delimiter to be converted.
Collaborator
Author
|
@WendellLiu This PR is ready. Please let me know if there are any changes needed. |
WendellLiu
reviewed
Nov 18, 2024
WendellLiu
approved these changes
Dec 2, 2024
| import PropTypes from 'prop-types'; | ||
| import cn from 'classnames'; | ||
|
|
||
| const ToggleButton = ({ isActive = false, onClick = () => {}, children = '', label = '' }) => { |
Collaborator
There was a problem hiding this comment.
I believe you can just leave it with no default value for children. Empty string should be okay but let's make it close to React tradition.
shinyu0430
force-pushed
the
feat/add-convert-modal
branch
from
d8cc1a7 to
2976a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.