fix: fix SVG image error by adding file extension #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WendellLiu
reviewed
Mar 17, 2025
Collaborator
Author
|
@WendellLiu This PR is ready. Please let me know if there are any changes needed. |
WendellLiu
reviewed
Mar 31, 2025
shinyu0430
force-pushed
the
fix/svg-issue
branch
from
c83ab83 to
cb644e2
Compare
WendellLiu
approved these changes
Apr 10, 2025
Collaborator
WendellLiu
left a comment
WendellLiu
left a comment
There was a problem hiding this comment.
Hi @shinyu0430,
Could we avoid rebasing the branch once the PR has been reviewed? This would allow the reviewer to utilize the "Show changes since your last review" feature on GitHub PR pages, which highlights only the changes made by the author since the last review. Otherwise, the reviewer may struggle to track their feedback and will need to review all files, including previous changes.
Collaborator
Author
|
@WendellLiu Sure, thank you for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix svg issue:
<img src="example">to<img src="example.svg">