fix: fix kv equality check for empty values#539
Merged
talos-bot merged 1 commit intocosi-project:mainfrom Dec 19, 2024
Merged
Conversation
utkuozdemir
force-pushed
the
fix-kv-equality
branch
from
10afff8 to
6c156f7
Compare
DmitriyMV
approved these changes
Dec 19, 2024
DmitriyMV
reviewed
Dec 19, 2024
utkuozdemir
force-pushed
the
fix-kv-equality
branch
from
6c156f7 to
08bf8b6
Compare
We did not distinguish between an entry with an empty value vs a non-existent key. This caused resource labels/annotations to not get updated in some cases. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
force-pushed
the
fix-kv-equality
branch
from
08bf8b6 to
eea1d62
Compare
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did not distinguish between an entry with an empty value vs a non-existent key. This caused resource labels/annotations to not get updated in some cases.