feat(erc20): accept hex addresses in erc20 callbacks #701
+421
−420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
reviewed
Oct 10, 2025
|
NIt: could we undo the weird spacing changes introduced by this commit 7be479d? It makes diffs harder to read, especially for argument/param lists. |
srdtrk
approved these changes
Oct 10, 2025
3 tasks
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
* use address codec in erc20 callbacks * add test and ibc-go v10.4.0 as a hash (temporarily) * lint * cl cl cl * systest gomod * rename encodings * use accountkeeper * remove weird helper function * rename misleading test * fix comments * undo spacing * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #570
Adds the address codec in ERC20 callbacks to allow for 0x recipients to unescrow their native ERC20s after they had sent it to another chain. Tested with an integration test.