You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR refactors all directional class names (pr-*, pl-*, mr-*, ml-*, left-*, right-*, etc) to contextual equivalents (pe-*, ps-*, me-*, ms-*, start-*, end-*, etc) to better support RTL languages like Hebrew and Arabic. By making these classes directionally agnostic, the layout will adjust dynamically based on text direction, improving flexibility and localization.
Hey @nahasco@pasqualevitiello , I intentionally forced the phone number input to be left-to-right as the preliminary dropdown is for the country code which will always be left to the phone number, also in Arabic and Hebrew. It is in fact may be problematic as the direction applies also to the label and all the elements surrounding the field so I'll try later to revise it and cover it as well.
Thanks for confirming @iftachhh, ltr property was just restored: 6ac4ffa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors all directional class names (
pr-*,pl-*,mr-*,ml-*,left-*,right-*, etc) to contextual equivalents (pe-*,ps-*,me-*,ms-*,start-*,end-*, etc) to better support RTL languages like Hebrew and Arabic. By making these classes directionally agnostic, the layout will adjust dynamically based on text direction, improving flexibility and localization.BEFORE (demo page with
dir=rtl):AFTER: