-
Notifications
You must be signed in to change notification settings - Fork 450
Pasquale/cui 96 move shadcnradix instructions to a separate page #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pasquale/cui 96 move shadcnradix instructions to a separate page #603
Conversation
…shadcnradix-instructions-to-a-separate-page
…shadcnradix-instructions-to-a-separate-page
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…clarity and key differences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 34 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/ui/content/docs/(root)/radix-shadcn-migration.mdx">
<violation number="1" location="apps/ui/content/docs/(root)/radix-shadcn-migration.mdx:104">
P3: Grammar error: "a error" should be "an error".</violation>
<violation number="2" location="apps/ui/content/docs/(root)/radix-shadcn-migration.mdx:656">
P1: The `items` variable is not in scope. It's passed as a prop to `<Select>` but referenced directly in the JSX children. Define `items` as a constant before the JSX, then reference it in both places.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| | `info` | Displays an info alert (blue) | | ||
| | `success` | Displays a success alert (green) | | ||
| | `warning` | Displays a warning alert (yellow) | | ||
| | `error` | Displays a error alert (red) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Grammar error: "a error" should be "an error".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/ui/content/docs/(root)/radix-shadcn-migration.mdx, line 104:
<comment>Grammar error: "a error" should be "an error".</comment>
<file context>
@@ -0,0 +1,953 @@
+| `info` | Displays an info alert (blue) |
+| `success` | Displays a success alert (green) |
+| `warning` | Displays a warning alert (yellow) |
+| `error` | Displays a error alert (red) |
+
+Ensure you have the following variables imported in your CSS file:
</file context>
✅ Addressed in 2a870f2
| <SelectValue /> | ||
| </SelectTrigger> | ||
| <SelectPopup alignItemWithTrigger={false}> | ||
| {items.map((item) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: The items variable is not in scope. It's passed as a prop to <Select> but referenced directly in the JSX children. Define items as a constant before the JSX, then reference it in both places.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/ui/content/docs/(root)/radix-shadcn-migration.mdx, line 656:
<comment>The `items` variable is not in scope. It's passed as a prop to `<Select>` but referenced directly in the JSX children. Define `items` as a constant before the JSX, then reference it in both places.</comment>
<file context>
@@ -0,0 +1,953 @@
+ <SelectValue />
+ </SelectTrigger>
+ <SelectPopup alignItemWithTrigger={false}>
+ {items.map((item) => (
+ <SelectItem key={item.value} value={item}>
+ {item.label}
</file context>
sean-brydon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is super nice to just feed to LLMs now! Nice job
Summary by cubic
Moves all Radix/shadcn migration guidance into a dedicated page and removes duplicated comparison content from component docs. Clarifies the Base UI positioning on the overview and links to the new migration guide. Addresses CUI-96.
Migration
Bug Fixes
Written for commit 2a870f2. Summary will update automatically on new commits.