refactor: remove onMouseDown event from ComboboxChips#676
Merged
pasqualevitiello merged 3 commits intomainfrom Feb 13, 2026
Merged
refactor: remove onMouseDown event from ComboboxChips#676pasqualevitiello merged 3 commits intomainfrom
pasqualevitiello merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
pasqualevitiello
changed the title
eunjae-lee
approved these changes
Feb 12, 2026
Co-Authored-By: pasquale@cal.com <pasqualevitiello@gmail.com>
Co-Authored-By: pasquale@cal.com <pasqualevitiello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes weird behavior on the combobox component with multiple selection. In simple terms, when the user clicks the combobox chips container we had an onMouseDown event that makes the container get a focus style but the popup does not actually open. So I've removed that functionality to prevent any weird and confusing behavior.
Before
Screen.Recording.2026-02-11.at.11.16.19.mov
After
Screen.Recording.2026-02-11.at.11.16.40.mov