feat(error): enhance error logging with tracing integration#186
feat(error): enhance error logging with tracing integration#186m4tx merged 1 commit intocot-rs:masterfrom
Conversation
|
The CI test failure appears to be due to a dependency ( Error message: error: failed to parse manifest at `/Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hybrid-array-0.3.0/Cargo.toml`
Caused by:
feature `edition2024` is requiredThe CI test failure is actually related to this transitive dependency chain: We could:
Ill be happy to do any of them. Please let me know. @m4tx |
|
Updating our MSRV (so option 3) to 1.85 is fine; we'll want to upgrade to edition 2024 soon anyways, and maintaining a stable MSRV isn't super important at this stage of the project development anyway. Thanks! |
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
m4tx
left a comment
There was a problem hiding this comment.
I took the liberty of fixing the dependency issue, since it was causing problems elsewhere, too (see #187).
The change looks good to me; please ensure the macro invocations are consistently formatted (see my review comments), and please fix the cargo fmt issues, and then it'll be ready to merge!
|
Thank you Ill keep that in mind for future contributions. |
c0cd3ea to
36ce724
Compare
Add structured logging for errors and panics using the tracing crate to improve observability. This change enables better integration with OpenTelemetry for monitoring errors in production services. - Add structured error logging with metadata - Include request context in error logs - Add backtrace information to error spans - Add comprehensive test coverage for logging(although some match the older ones) - Maintain existing error page functionality The logging implementation includes: - Error type and message - Stack traces- Request information (method, path) - Proper span contexts for OpenTelemetry Fixes cot-rs#160
36ce724 to
7a4b4c8
Compare
m4tx
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for the contribution!
This PR enhances error logging in Cot by implementing structured logging with the tracing crate. The goal is to improve observability and enable better integration with OpenTelemetry for monitoring errors in production services.
Changes:
Added new tests that verify:
related Issues
Implements better error monitoring as discussed in issue #160