Conversation
m4tx
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release-plz changelog template and preprocessing rules to better handle revert commits and commits without associated PR metadata.
Changes:
- Only group/render commits that have a
remote.pr_number, and correctly iterate per-group commits. - Add a separate rendering pass for commits missing
remote.pr_numberso they still appear in the changelog. - Add a commit preprocessor to rewrite auto-generated “Revert …” commit subjects into a conventional-commit style prefix.
Comments suppressed due to low confidence (1)
release-plz.toml:1
- Commit rendering logic is now duplicated across two paths (grouped commits vs. commits without
remote.pr_number), and the new non-PR rendering path doesn’t handlecommit.scopethe same way. To keep formatting consistent and reduce drift, consider extracting a small macro (e.g.,render_commit(commit)) and calling it from both loops.
[workspace]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+53
| {%- for commit in commits -%} | ||
| {%- if not commit.remote.pr_number %} | ||
| - {% if commit.breaking %}[**breaking**] {% endif %}{{ commit.message | upper_first }}{{ self::username(commit=commit) }} | ||
| {%- endif -%} | ||
| {%- endfor %} |
| { pattern = "([ \\n])(([a-f0-9]{7})[a-f0-9]*)", replace = "${1}commit [${3}](https://github.com/cot-rs/cot/commit/${2})" } | ||
| { pattern = "([ \\n])(([a-f0-9]{7})[a-f0-9]*)", replace = "${1}commit [${3}](https://github.com/cot-rs/cot/commit/${2})" }, | ||
| # Fix automatic revert commit name | ||
| { pattern = "^Revert", replace = "chore(revert):" } |
|
Bencher Report| Branch | release-plz-fiz |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6.58 ms(+10.55%)Baseline: 5.95 ms | 7.09 ms (92.78%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.09 ms(+6.15%)Baseline: 1.03 ms | 1.19 ms (92.24%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.02 ms(+7.94%)Baseline: 0.95 ms | 1.08 ms (94.60%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.00 ms(+10.32%)Baseline: 0.91 ms | 1.04 ms (96.31%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 20.26 ms(+15.51%)Baseline: 17.54 ms | 20.76 ms (97.61%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.