Skip to content

feat(orm): varchar(n) support#64

Merged
m4tx merged 2 commits intomasterfrom
varchar-support
Nov 8, 2024
Merged

feat(orm): varchar(n) support#64
m4tx merged 2 commits intomasterfrom
varchar-support

Conversation

@m4tx
Copy link
Member

@m4tx m4tx commented Nov 6, 2024

No description provided.

@m4tx m4tx requested review from Iipin and seqre November 6, 2024 16:24
@m4tx m4tx marked this pull request as draft November 6, 2024 16:32
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 94.21488% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
flareon/src/db.rs 92.95% 5 Missing ⚠️
flareon/src/auth.rs 83.33% 1 Missing ⚠️
flareon/src/auth/db.rs 97.22% 1 Missing ⚠️
Flag Coverage Δ
rust 78.08% <94.21%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
flareon/src/auth/db/migrations/m_0001_initial.rs 0.00% <ø> (ø)
flareon/src/db/fields.rs 76.00% <100.00%> (+9.33%) ⬆️
flareon/src/db/migrations.rs 83.07% <100.00%> (+0.05%) ⬆️
flareon/tests/db.rs 100.00% <ø> (ø)
flareon/src/auth.rs 93.90% <83.33%> (-0.14%) ⬇️
flareon/src/auth/db.rs 80.85% <97.22%> (+1.91%) ⬆️
flareon/src/db.rs 93.33% <92.95%> (-0.12%) ⬇️

@m4tx m4tx marked this pull request as ready for review November 6, 2024 18:52
Copy link
Member

@seqre seqre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM with a few comments

}

#[cfg(feature = "fake")]
impl<const LIMIT: u32> fake::Dummy<fake::Faker> for LimitedString<LIMIT> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Łaka maka fą

@m4tx m4tx merged commit c7bbf69 into master Nov 8, 2024
@m4tx m4tx deleted the varchar-support branch November 8, 2024 14:54
m4tx added a commit that referenced this pull request Feb 23, 2026
Co-authored-by: Mateusz Maćkowski <m4tx@m4tx.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants