Skip to content

DA-951 Modified Edge Server SKO Demo Improvements #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

DA-951 Modified Edge Server SKO Demo Improvements #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tutorial/markdown/mobile/couchbase-edge-server/edge-server-demo-meal-app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ Follow these steps to set up and run the application locally on the same machine

* **Clone the Repository**:
```bash
git clone <repository-url>
git clone https://github.com/couchbase-examples/edge-server-meal-order-sample-app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The git clone command now correctly points to the edge-server-meal-order-sample-app repository. That's a good fix for the placeholder!

However, there's a potential issue: the subsequent command on line 160, cd edge-server-sko-demo, will likely fail. Cloning the repository https://github.com/couchbase-examples/edge-server-meal-order-sample-app will, by default, create a directory named edge-server-meal-order-sample-app.

To ensure the cd edge-server-sko-demo command works as written, should the git clone command specify edge-server-sko-demo as the target directory name?

Alternatively, if the directory name edge-server-sko-demo is no longer intended, the cd command on line 160 would need to be updated to cd edge-server-meal-order-sample-app. Since line 160 is not part of this diff, modifying the clone command on this line to create the correctly named directory seems like the most direct solution within this change.

Suggested change
git clone https://github.com/couchbase-examples/edge-server-meal-order-sample-app
git clone https://github.com/couchbase-examples/edge-server-meal-order-sample-app edge-server-sko-demo

cd edge-server-sko-demo
```

Expand Down