Skip to content

Conversation

@DemetrisChr
Copy link
Contributor

  • Add missing close_connection and reset_client in core _ClientAdapter.
  • Don't ignore the event loop parameter in AsyncCluster.create_instance()
  • Remove Event loop is not running check when creating an AsyncCluster (?)
  • Update C++ core

Copy link
Collaborator

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can either:

  1. move the running event loop check into the loop property because that would be the point at which we actually need the event loop
  2. Rely on the Python environment to complain about a non-running event loop.

With the current changes, we have #2 already so lets see if that does all that we need.

@thejcfactor thejcfactor merged commit 5614784 into couchbase:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants