CXXCBC-757: Replica get/lookup_in - add sub-op spans & parent span option in core #866
+369
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemetrisChr
force-pushed
the
CXXCBC-757-replica-get-spans
branch
from
6b2008f to
8a92867
Compare
avsej
approved these changes
Nov 14, 2025
DemetrisChr
force-pushed
the
CXXCBC-757-replica-get-spans
branch
2 times, most recently
from
766384b to
9d38add
Compare
Contributor
Author
|
Moving to draft temporarily until #869 is merged |
DemetrisChr
force-pushed
the
CXXCBC-757-replica-get-spans
branch
from
9d38add to
7e1ac8d
Compare
DemetrisChr
force-pushed
the
CXXCBC-757-replica-get-spans
branch
from
7e1ac8d to
6356a98
Compare
avsej
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The replica get operations in the core were missing the parent span option. Spans for each individual get_replica/lookup_in_replica operation should also be created.
Changes