Fixed #1033 - Requests pending with POST _bulk_docs#1034
Merged
Conversation
##### Problem: - _bulk_docs: Calling synchronized(db) in transaction wait for db lock with holding SQLite connection - other request: waiting for SQLConnection with holding db lock. ##### Solution: Router.java: - Eliminate all synchronized block from Router as most of database access are protected by Transaction. - Use runInTransaction for putLocalRevision() which is not inTransaction Database.java: - make compact() thread-safe Concern: - Database.delete() and Database.close()'s thread-safety. Need to review later.
zgramana
added a commit
that referenced
this pull request
Feb 14, 2016
…k_docs_hang
Fixed #1033 - Requests pending with POST _bulk_docs
| store.compact(); | ||
| synchronized (store) { | ||
| store.compact(); | ||
| } |
Contributor
There was a problem hiding this comment.
There is nothing wrong with this synchronized. I checked the Database.java code and found that some code path does synchronized (store) but some not. If the intension to make Database thread safe, all of those synchronized (store) and not synchronized (store) should be revised.
Author
There was a problem hiding this comment.
I have same concern. I would like to fix this issue with new ticket. https://github.com/couchbase/couchbase-lite-java-core/issues/1035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Router.java:
Database.java:
Concern: