Skip to content

Fixed #604 - incompatible attachment path#605

Merged
pasin merged 5 commits intorelease/1.1.0from
feature/issue_604_incompatible_attachment_path
Apr 29, 2015
Merged

Fixed #604 - incompatible attachment path#605
pasin merged 5 commits intorelease/1.1.0from
feature/issue_604_incompatible_attachment_path

Conversation

@hideki
Copy link
Copy Markdown

@hideki hideki commented Apr 29, 2015

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this part into the if block (line 1220 - 1231)?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 1234-1237 should be out side of if block (line 1220 - 1231).

Previous version of CBL Android/Java creates the directory, /files/<database name>/ in case of no attachment. But does not create /files/<database name>/attachments.

@hideki
Copy link
Copy Markdown
Author

hideki commented Apr 29, 2015

@pasin
Could you please review again?

pasin added a commit that referenced this pull request Apr 29, 2015
…_attachment_path

Fixed #604 - incompatible attachment path
@pasin pasin merged commit c451bcd into release/1.1.0 Apr 29, 2015
@pasin pasin removed the in progress label Apr 29, 2015
@pasin pasin deleted the feature/issue_604_incompatible_attachment_path branch April 29, 2015 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants