RCBC-542: Forward CAS to C++ Core in Append/Prepend#225
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Apr 16, 2026
Merged
RCBC-542: Forward CAS to C++ Core in Append/Prepend#225DemetrisChr merged 1 commit intocouchbase:mainfrom
DemetrisChr merged 1 commit intocouchbase:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes CAS handling for binary append/prepend by ensuring the CAS option is forwarded from the Ruby layer into the C++ core request, and adds regression tests for CAS mismatch behavior.
Changes:
- Forward
casfrom Ruby options intocore::operations::{append,prepend}_request. - Add tests asserting
append/prependraiseCouchbase::Error::CasMismatchwhen given a bad CAS. - Pin development OpenTelemetry gem versions in
Gemfile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ext/rcb_crud.cxx |
Adds cb_extract_cas(req, options) to append/prepend backend operations so CAS is included in core requests. |
test/crud_test.rb |
Adds regression tests for CAS mismatch on binary append/prepend. |
Gemfile |
Pins opentelemetry-metrics-sdk and opentelemetry-sdk versions for development. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c9cd20d to
b22adf5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avsej
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The CAS option was being ignored in the append & prepend operations, and not being passed on to the C++ core.
Changes