RCBC-535: Upgrade to Minitest 6#228
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the development dependency on Minitest to the 6.x series and adds the newly-separate minitest-mock gem (Minitest 6 no longer bundles mock/stub support), which is required by the Active Support–derived test cases that rely on Time.stub and ActiveSupport::Testing::MethodCallAssertions. The PR also re-enables three previously skipped scan concurrency tests.
Changes:
- Pin
minitestto~> 6.0(previously< 6.0) in the:developmentgroup of theGemfile. - Add
minitest-mockas an explicit development dependency. - Remove
skip("Skipped until CXXCBC-345 is resolved")from the three scan concurrency tests intest/scan_test.rb.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Gemfile | Bumps minitest to ~> 6.0 and adds the standalone minitest-mock gem needed for Time.stub and friends. |
| test/scan_test.rb | Removes CXXCBC-345 skip guards from the range/prefix/sampling scan concurrency tests, re-enabling them in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avsej
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only change we need is adding
minitest-mockas a dependency (no longer bundled withminitest), which is needed for the active support test cases.